-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Attempt to fix tests build for android #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix tests build for android #1330
Conversation
|
I'm launching them. A maintainer needs to approve them for for new contributors to run. |
|
Got it, I thought that it just took some extra time to start and removed my question 🤦 |
|
"Segmentation fault " - that interesting. I will try to reproduce locally a bit later. |
|
I decided not to fully reproduce this CI’s approach, since it seems to work only on Ubuntu — and I would need an emulator-in-emulator setup (Android on Ubuntu), which AFAIK my M1 can’t handle. |
|
Looks like same bug, as for linux - #1071 . Which make sense... Pushing fixes. |
|
@nathanfallet I'm not familiar with setup of test for iOS - but my changes can't break it. |
|
@NikolayJuly Try opening Xcode to launch manually an iPhone 16 on iOS 18.0 simulator, so it's created once and then it will find it. If you updated your Mac to a more recent version, you might have to manually download it from the "Windows & Simulator" menu. |
|
@nathanfallet I think you might misundertood the problem. Error from CI, not from my local. CI doesn't have this simulator. I can spend extra time on it ofc, but it will requre me to dig through current CI setup... I would prefer to avoid it. |
|
Looks like iOS CI start failing here - #1326 |
The iOS CI failure is due to actions/runner-images#12758 (comment) |
|
I get it. So we should update the iOS tests to use the latest available iOS instead of a fixed version maybe? |
As I understand it, the options are to:
|
|
Option 3 looks okay for me, especially since I'm now trying to push my package to production on Android. I might have more info/ideas in 5 days. @marcprux thank you for digging up this info! |
I surmise from the 100+ comments on that thread — before they had to lock it — that they didn't quite think through the consequences of the change. It basically broke every iOS CI that uses the default configuration on macOS-15 runners. In their defense, they usually give a bit more warning about breaking changes like these. |
|
@nathanfallet If I understood situation correctly - if you run iOS CI again, it will pull updated image with xcode 16.4 and sim installed there. Can you try to run it, please? |
|
@NikolayJuly I did but it was still failing. I updated the device name to match what was mentioned in the available devices in the error and maybe this time it will work. EDIT: Does not work either. I get the same error but the other way: While before it was: (that's why I changed the name at the first place) |
|
@nathanfallet I've seen initial failure, I also notice that device list first time didn't contain any actual sim. And on second run there was big list of simulators.... But looks like latest changes actually trigger test run on sim. May be worth consider later for separate PR smth like take list from |
|
@NikolayJuly yes it looks like it works with the latest one. We might have to either keep updating it manually or have it removed/automatically select it so we don't have it broken. At least I'll merge this one if it works because the initial goal was to fix android build. But if you feel brave enough to try this we can open a new PR for it just after merging this one. |
No description provided.